Skip to content

rustdoc: Fix ICE with doc(hidden) on tuple variant fields#88639

Merged
bors merged 1 commit intorust-lang:masterfrom
Emilgardis:fix-issue-88600
Sep 11, 2021
Merged

rustdoc: Fix ICE with doc(hidden) on tuple variant fields#88639
bors merged 1 commit intorust-lang:masterfrom
Emilgardis:fix-issue-88600

Conversation

@Emilgardis
Copy link
Contributor

@Emilgardis Emilgardis commented Sep 4, 2021 •
edited
Loading

Fixes #88600.

pub struct H;
pub struct S;

pub enum FooEnum {
    HiddenTupleItem(#[doc(hidden)] H),
    MultipleHidden(#[doc(hidden)] H, #[doc(hidden)] H),
    MixedHiddenFirst(#[doc(hidden)] H, S),
    MixedHiddenLast(S, #[doc(hidden)] H),
    HiddenStruct {
        #[doc(hidden)]
        h: H,
        s: S,
    },
}

Generates
image

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

rustdoc ICE: entered unreachable code on hidden tuple item

10 participants

@Emilgardis @rust-highfive @GuillaumeGomez @rust-log-analyzer @jyn514 @camelid @Manishearth @bors @cuviper @rustbot